Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where a new line in the composer could move the caret. #3114

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 5, 2024

Fixes #3104.

The diffs revealed some missing attributes on the new line so I'm only restoring the selection when the plain string is unchanged.

@pixlwave pixlwave added the pr-bugfix for bug fix label Aug 5, 2024
@pixlwave pixlwave requested a review from a team as a code owner August 5, 2024 11:28
@pixlwave pixlwave requested review from Velin92 and removed request for a team August 5, 2024 11:28
Copy link

github-actions bot commented Aug 5, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 756d25d

@pixlwave pixlwave force-pushed the doug/fix-composer-selection branch from d916dbd to 756d25d Compare August 5, 2024 11:31
Copy link

sonarcloud bot commented Aug 5, 2024

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.57%. Comparing base (cdaa88e) to head (756d25d).
Report is 1 commits behind head on develop.

Files Patch % Lines
...omposerToolbar/View/MessageComposerTextField.swift 50.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3114      +/-   ##
===========================================
- Coverage    77.80%   77.57%   -0.24%     
===========================================
  Files          713      714       +1     
  Lines        54994    55386     +392     
===========================================
+ Hits         42786    42963     +177     
- Misses       12208    12423     +215     
Flag Coverage Δ
unittests 68.32% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 6a45ffc into develop Aug 5, 2024
10 checks passed
@pixlwave pixlwave deleted the doug/fix-composer-selection branch August 5, 2024 13:46
@pixlwave pixlwave changed the title Fix a bug where moving a new line in the composer could move the caret. Fix a bug where a new line in the composer could move the caret. Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor jumps in composer
3 participants