Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalise strings/icons for EncryptionAuthenticity. #3121

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 6, 2024

The final designs are now available, so this uses the correct icons and updates a localised string.

@pixlwave pixlwave requested a review from a team as a code owner August 6, 2024 13:06
@pixlwave pixlwave requested review from stefanceriu and removed request for a team August 6, 2024 13:06
Copy link

github-actions bot commented Aug 6, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 07a4524

@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.42%. Comparing base (0c9da2c) to head (07a4524).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3121   +/-   ##
========================================
  Coverage    77.41%   77.42%           
========================================
  Files          714      714           
  Lines        55355    55359    +4     
========================================
+ Hits         42855    42859    +4     
  Misses       12500    12500           
Flag Coverage Δ
unittests 68.29% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@pixlwave pixlwave merged commit e2712f6 into develop Aug 6, 2024
11 checks passed
@pixlwave pixlwave deleted the doug/authenticity-icons branch August 6, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants