Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force update the home screen every time the room list changes by manually moving the inner scrollview #3122

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

stefanceriu
Copy link
Member

Force update the home screen every time the room list changes by manually moving the inner scrollview

We have been seeing a lot of issues around the room list not updating properly after
rooms shifting around:

We initially thought it's caused by the filters header or the geometry reader but
the problem is still reproducible without those.

As a last attempt we will manually force it to update by shifting the
inner scroll view by a point every time the room list is updated

@stefanceriu stefanceriu requested a review from a team as a code owner August 6, 2024 14:37
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team August 6, 2024 14:37
Copy link

github-actions bot commented Aug 6, 2024

Fails
🚫

Please add a pr- label to categorise the changelog entry.

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against ec74e15

Copy link

sonarcloud bot commented Aug 6, 2024

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.52%. Comparing base (0c9da2c) to head (ec74e15).
Report is 2 commits behind head on develop.

Files Patch % Lines
...es/Screens/HomeScreen/View/HomeScreenContent.swift 95.65% 1 Missing ⚠️
...ervices/Room/RoomSummary/RoomSummaryProvider.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3122      +/-   ##
===========================================
+ Coverage    77.41%   77.52%   +0.10%     
===========================================
  Files          714      715       +1     
  Lines        55355    55701     +346     
===========================================
+ Hits         42855    43180     +325     
- Misses       12500    12521      +21     
Flag Coverage Δ
unittests 68.43% <91.66%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit 8f922ac into develop Aug 6, 2024
9 of 10 checks passed
@stefanceriu stefanceriu deleted the stefan/3026 branch August 6, 2024 18:30
stefanceriu added a commit that referenced this pull request Aug 7, 2024
…e displayed

- while looking into fixes we noticed that we can more easily break the layout when the search field is automatically hidden
stefanceriu added a commit that referenced this pull request Aug 7, 2024
…e displayed

- while looking into fixes we noticed that we can more easily break the layout when the search field is automatically hidden
stefanceriu added a commit that referenced this pull request Aug 7, 2024
…e displayed

- while looking into fixes we noticed that we can more easily break the layout when the search field is automatically hidden
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants