PinnedBanner is now managed by the RoomScreenViewModel #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Velin92
force-pushed
the
mauroromito/room_screen_refactor_part_1
branch
from
3e59ae8
to
55a7b8f
Compare
Generated by 🚫 Danger Swift against 45f3a72 |
Velin92
added
the
pr-wip
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3163 +/- ##
===========================================
+ Coverage 73.84% 74.00% +0.15%
===========================================
Files 768 769 +1
Lines 60440 60611 +171
===========================================
+ Hits 44634 44854 +220
+ Misses 15806 15757 -49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pixlwave
approved these changes
Aug 14, 2024
ElementX/Sources/Screens/PinnedEventsTimelineScreen/View/PinnedEventsTimelineScreen.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/RoomScreenCoordinator.swift
Outdated
Show resolved
Hide resolved
Velin92
force-pushed
the
mauroromito/room_screen_refactor_part_1
branch
from
d5cedc9
to
45f3a72
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor also includes finally some meaningful tests!
Timeline view model banner logic has been removed and inserted in the room screen view model. It also includes some other bugfixes and UX improvements on the PinnedEventsTimelineView