Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation support for upcoming Element Call Picture in Picture mode. #3174

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

pixlwave
Copy link
Member

This PR adds the initial support for EC PiP with the following changes:

  • Replace the sheet with a SwiftUI fullscreen overlay (so we can hide the web view without removing it from the view hierarchy).
  • Listen for AVPictureInPictureController notifications and use these to show/hide the call overlay.
  • Make sure that joining the same call that's running in PiP, dismisses the PiP instead of creates a new call.
  • Dismiss the composer before starting a call (as there's no longer a sheet to take the focus away).

@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Aug 16, 2024
@pixlwave pixlwave requested a review from a team as a code owner August 16, 2024 09:09
@pixlwave pixlwave requested review from Velin92 and stefanceriu and removed request for a team and Velin92 August 16, 2024 09:09
Copy link

github-actions bot commented Aug 16, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against b9fa309

Copy link

sonarcloud bot commented Aug 16, 2024

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 53.42466% with 102 lines in your changes missing coverage. Please review.

Project coverage is 77.18%. Comparing base (cf35056) to head (b9fa309).
Report is 4 commits behind head on develop.

Files Patch % Lines
...urces/Screens/CallScreen/CallScreenViewModel.swift 0.00% 42 Missing ⚠️
...X/Sources/Screens/CallScreen/View/CallScreen.swift 0.00% 20 Missing ⚠️
.../FlowCoordinators/UserSessionFlowCoordinator.swift 0.00% 18 Missing ⚠️
...pplication/Navigation/NavigationCoordinators.swift 78.43% 11 Missing ⚠️
...ces/Screens/CallScreen/CallScreenCoordinator.swift 0.00% 5 Missing ⚠️
...ces/Screens/RoomScreen/RoomScreenCoordinator.swift 0.00% 2 Missing ⚠️
...ests/Sources/NavigationSplitCoordinatorTests.swift 97.43% 2 Missing ⚠️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 0.00% 1 Missing ⚠️
...rces/Services/ElementCall/ElementCallService.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3174      +/-   ##
===========================================
- Coverage    77.33%   77.18%   -0.15%     
===========================================
  Files          717      717              
  Lines        56141    56501     +360     
===========================================
+ Hits         43415    43609     +194     
- Misses       12726    12892     +166     
Flag Coverage Δ
unittests 68.37% <53.42%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to comment, looks great! 👏

@pixlwave pixlwave merged commit ebf7c00 into develop Aug 16, 2024
10 checks passed
@pixlwave pixlwave deleted the doug/av-picture-in-picture branch August 16, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants