Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new RoomProxyType and treat rooms differently based on their membership state #3187

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-api for an api break label Aug 20, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner August 20, 2024 13:25
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team August 20, 2024 13:25
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice tidy-up, this is much safer 👏👏👏

Did it need any Rust changes in the end?

Copy link

github-actions bot commented Aug 21, 2024

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against a11b549

Copy link

sonarcloud bot commented Aug 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
9.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 85.36585% with 30 lines in your changes missing coverage. Please review.

Project coverage is 77.66%. Comparing base (e0ba992) to head (a11b549).
Report is 1 commits behind head on develop.

Files Patch % Lines
ElementX/Sources/Application/AppCoordinator.swift 0.00% 9 Missing ⚠️
...urces/Screens/HomeScreen/HomeScreenViewModel.swift 76.66% 7 Missing ⚠️
...reens/JoinRoomScreen/JoinRoomScreenViewModel.swift 77.77% 6 Missing ⚠️
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 66.66% 3 Missing ⚠️
.../FlowCoordinators/UserSessionFlowCoordinator.swift 0.00% 2 Missing ⚠️
...X/Sources/Screens/CallScreen/View/CallScreen.swift 0.00% 1 Missing ⚠️
...en/NotificationSettingsEditScreenCoordinator.swift 0.00% 1 Missing ⚠️
...rces/Services/ElementCall/ElementCallService.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3187      +/-   ##
===========================================
- Coverage    77.90%   77.66%   -0.25%     
===========================================
  Files          717      718       +1     
  Lines        56527    56617      +90     
===========================================
- Hits         44039    43970      -69     
- Misses       12488    12647     +159     
Flag Coverage Δ
unittests 68.39% <85.36%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit e281a3f into develop Aug 21, 2024
9 of 10 checks passed
@stefanceriu stefanceriu deleted the stefan/differentRoomTypes branch August 21, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-api for an api break
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants