Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimelineKind refactor #3193

Merged
merged 6 commits into from
Aug 22, 2024
Merged

TimelineKind refactor #3193

merged 6 commits into from
Aug 22, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Aug 22, 2024

isLive has been replaced with a TimelineKind enum to allow a better handling of the pinned timeline

@Velin92 Velin92 requested a review from a team as a code owner August 22, 2024 15:39
@Velin92 Velin92 requested review from pixlwave and removed request for a team August 22, 2024 15:39
Copy link

github-actions bot commented Aug 22, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against da224a6

@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Aug 22, 2024
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this feels much clearer about what's going on and will scale much better if we add another type of timeline in the future. 🙌

@Velin92 Velin92 force-pushed the mauroromito/timeline_kind_refactor branch from 02f0a4f to e66b16d Compare August 22, 2024 17:15
@Velin92 Velin92 enabled auto-merge (squash) August 22, 2024 17:17
Copy link

sonarcloud bot commented Aug 22, 2024

@Velin92 Velin92 merged commit 993fe8c into develop Aug 22, 2024
6 checks passed
@Velin92 Velin92 deleted the mauroromito/timeline_kind_refactor branch August 22, 2024 18:33
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.21%. Comparing base (8c07397) to head (da224a6).
Report is 1 commits behind head on develop.

Files Patch % Lines
...ne/TimelineController/RoomTimelineController.swift 0.00% 5 Missing ⚠️
...urces/Services/Timeline/RoomTimelineProvider.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3193      +/-   ##
===========================================
- Coverage    77.21%   77.21%   -0.01%     
===========================================
  Files          719      719              
  Lines        57044    57033      -11     
===========================================
- Hits         44047    44036      -11     
  Misses       12997    12997              
Flag Coverage Δ
unittests 68.18% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants