Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the maximum height used by the plain text composer #3255

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

stefanceriu
Copy link
Member

Screenshot 2024-09-10 at 18 12 36

Screenshot 2024-09-10 at 18 13 13

@stefanceriu stefanceriu added the pr-bugfix for bug fix label Sep 10, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner September 10, 2024 15:14
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team September 10, 2024 15:14
Copy link

Fails
🚫 Please provide a complete title that can be used as a changelog entry.
Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 9ff164c

Copy link

sonarcloud bot commented Sep 10, 2024

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.01%. Comparing base (4ec6098) to head (9ff164c).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3255   +/-   ##
========================================
  Coverage    71.01%   71.01%           
========================================
  Files          734      734           
  Lines        65131    65131           
========================================
+ Hits         46255    46256    +1     
+ Misses       18876    18875    -1     
Flag Coverage Δ
unittests 68.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu changed the title Fixes #3249 - Converge on the same max height for both text composers. Reduce the maximum height used by the plain text composer Sep 11, 2024
@stefanceriu stefanceriu merged commit eb60a8d into develop Sep 11, 2024
12 of 13 checks passed
@stefanceriu stefanceriu deleted the stefan/3249 branch September 11, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants