Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace client side room awaiting with the SDKs new awaitRoomRemoteEcho method #3279

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Sep 13, 2024

Partially fixes #3256 where the join room screen doesn't have details about an invited room because the sync loop hasn't run yet (the preview api can't help here either because previews are disabled). Also fixes edgecases in which the room summary was available but the room not fully synced when used for creating/joining rooms.

  • the part about the push notification not having content seems to be related to a missing event_id field between SS and SSS

Requires matrix-org/matrix-rust-sdk#3979

@stefanceriu stefanceriu requested a review from a team as a code owner September 13, 2024 10:29
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team September 13, 2024 10:29
Copy link

github-actions bot commented Sep 13, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 02d9e65

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

Is there another place where we do this? Maybe the whole can init timeline thing? Or would that not work?

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 15.78947% with 16 lines in your changes missing coverage. Please review.

Project coverage is 77.61%. Comparing base (47a093e) to head (02d9e65).
Report is 4 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...urces/Screens/HomeScreen/HomeScreenViewModel.swift 0.00% 12 Missing ⚠️
...ources/Services/UserSession/UserSessionStore.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3279      +/-   ##
===========================================
+ Coverage    77.57%   77.61%   +0.04%     
===========================================
  Files          725      725              
  Lines        58753    58757       +4     
===========================================
+ Hits         45578    45606      +28     
+ Misses       13175    13151      -24     
Flag Coverage Δ
unittests 69.02% <15.78%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 13, 2024

@stefanceriu stefanceriu enabled auto-merge (rebase) September 13, 2024 12:18
@stefanceriu stefanceriu merged commit ce83aec into develop Sep 13, 2024
9 checks passed
@stefanceriu stefanceriu deleted the stefan/waitForRooms branch September 13, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New invites show entirely blank push notifs and room profiles.
2 participants