-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace client side room awaiting with the SDKs new awaitRoomRemoteEcho
method
#3279
Conversation
Generated by 🚫 Danger Swift against 02d9e65 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
Is there another place where we do this? Maybe the whole can init timeline thing? Or would that not work?
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #3279 +/- ##
===========================================
+ Coverage 77.57% 77.61% +0.04%
===========================================
Files 725 725
Lines 58753 58757 +4
===========================================
+ Hits 45578 45606 +28
+ Misses 13175 13151 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8af3ed1
to
02d9e65
Compare
Quality Gate passedIssues Measures |
Partially fixes #3256 where the join room screen doesn't have details about an invited room because the sync loop hasn't run yet (the preview api can't help here either because previews are disabled). Also fixes edgecases in which the room summary was available but the room not fully synced when used for creating/joining rooms.
event_id
field between SS and SSSRequires matrix-org/matrix-rust-sdk#3979