Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the UI in the EncryptionReset, IdentityConfirmation and SecureBackupRecovery screens. #3391

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

pixlwave
Copy link
Member

Closes #3388.

EncryptionResetScreen IdentityConfirmationScreen SecureBackupRecoveryScreen
test_encryptionResetScreen-iPhone-16-en-GB 1 test_identityConfirmationScreen-iPhone-16-en-GB 1 test_secureBackupRecoveryKeyScreen-iPhone-16-en-GB Incomplete

@pixlwave pixlwave requested a review from a team as a code owner October 10, 2024 09:27
@pixlwave pixlwave requested review from stefanceriu and removed request for a team October 10, 2024 09:27
@pixlwave pixlwave added the pr-change for updates to an existing feature label Oct 10, 2024
@pixlwave pixlwave changed the title Tweak EncryptionReset, IdentityConfirmation and SecureBackupRecovery screens. Tweak the UI in the EncryptionReset, IdentityConfirmation and SecureBackupRecovery screens. Oct 10, 2024
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against d2ce16d

1 similar comment
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against d2ce16d

Copy link

sonarcloud bot commented Oct 10, 2024

Copy link

codecov bot commented Oct 10, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
840 2 838 0
View the full list of 2 ❄️ flaky tests
PreviewTests test_userProfileScreen()

Flake rate in main: 14.51% (Passed 218 times, Failed 37 times)

Stack Traces | 2.13s run time
failed - Snapshot "Other User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Other-User.png"
@+
"file:.../tmp/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Other-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9088135 is less than required 1.0
The lowest perceptual color precision 0.31062502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 16.50% (Passed 248 times, Failed 49 times)

Stack Traces | 41.5s run time
failed - Snapshot "Other User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Other-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Other-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.85461426 is less than required 1.0
The lowest perceptual color precision 0.148125 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

if shouldShowSkipButton {
Button(L10n.actionSkip) {
Button("\(L10n.actionSkip) 🙉") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@pixlwave pixlwave merged commit cd59e49 into develop Oct 10, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/verification-&-reset-copy branch October 10, 2024 10:27
@bmarty
Copy link
Member

bmarty commented Oct 10, 2024

@pixlwave you do have the "learn more" button on iOS?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Adjust EX device verification & key reset UI/copy
3 participants