Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove feature_dehydration #138

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Remove feature_dehydration #138

merged 6 commits into from
Oct 14, 2024
+3 −76

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Oct 9, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task element-hq/element-web#26922
matrix-org/matrix-spec-proposals#2697 is abandoned
The old dehydration feature is deprecated and not implemented in the rust crypto.
Remove the lab doc element-hq/element-web#28173

This was referenced Oct 9, 2024
Open
Open
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/remove-feature-dehydration branch from 398b6f3 to 1d3ca7a Compare October 9, 2024 16:08
@florianduros florianduros marked this pull request as ready for review October 9, 2024 16:25
@florianduros florianduros requested review from a team as code owners October 9, 2024 16:25
uhoreg
uhoreg requested changes Oct 9, 2024
View reviewed changes
src/SecurityManager.ts Outdated Show resolved Hide resolved
src/Lifecycle.ts Outdated Show resolved Hide resolved
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/remove-feature-dehydration branch from 346ef07 to 7fa97d4 Compare October 10, 2024 08:52
@florianduros florianduros added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@florianduros florianduros added this pull request to the merge queue Oct 14, 2024
Merged via the queue into develop with commit 63986f8 Oct 14, 2024
27 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/remove-feature-dehydration branch October 14, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@uhoreg uhoreg uhoreg approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

@richvdh richvdh Awaiting requested review from richvdh

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florianduros @dbkr @uhoreg