Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MatrixClient.isCryptoEnabled by MatrixClient.getCrypto #140

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Replace MatrixClient.isCryptoEnabled by MatrixClient.getCrypto #140

wants to merge 2 commits into from

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Oct 10, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task element-hq/element-web#26922
Replace the deprecated MatrixClient.isCryptoEnabled by MatrixClient.getCrypto

@florianduros florianduros added the T-Task Tasks for the team like planning label Oct 10, 2024
@florianduros florianduros mentioned this pull request Oct 10, 2024
Open
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/remove-isCryptoEnabled branch from bbfb413 to 0a8709f Compare October 10, 2024 13:38
@florianduros florianduros marked this pull request as ready for review October 10, 2024 14:04
@florianduros florianduros requested review from a team as code owners October 10, 2024 14:04
dbkr
dbkr reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't mind having an explicitly named function, but if that's what the API is now then I guess that's what we do.

src/components/structures/MatrixChat.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

@richvdh richvdh Awaiting requested review from richvdh

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @dbkr