Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MatrixClient.checkSecretStorageKey by MatrixClient.SecretStorage.checkKey #142

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Replace MatrixClient.checkSecretStorageKey by MatrixClient.SecretStorage.checkKey #142

merged 2 commits into from
Oct 14, 2024
+8 −10

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Oct 10, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task element-hq/element-web#26922
Replace deprecated MatrixClient.checkSecretStorageKey by MatrixClient.SecretStorage.checkKey

@florianduros florianduros mentioned this pull request Oct 10, 2024
Open
@florianduros florianduros added the T-Task Tasks for the team like planning label Oct 10, 2024
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/remove-checkSecretStorageKey branch from f70eedf to f005dcb Compare October 10, 2024 16:32
@florianduros florianduros marked this pull request as ready for review October 10, 2024 16:51
@florianduros florianduros requested review from a team as code owners October 10, 2024 16:51
@florianduros florianduros added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@florianduros florianduros added this pull request to the merge queue Oct 14, 2024
Merged via the queue into develop with commit 3bc0439 Oct 14, 2024
27 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/remove-checkSecretStorageKey branch October 14, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@robintown robintown robintown approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florianduros @andybalaam @robintown