Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outstanding UX issues with replies/mentions/keyword notifs #85

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

taffyko
Copy link

@taffyko taffyko commented Sep 23, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Purpose

For the "Modern" layout, a bright stripe has been added to the left edge of the highlighted-message background to improve visibility for mentions/notifications, in the spirit of element-hq/element-meta#1476.

Before After
Pasted image 20240922225036 Pasted image 20240922225435
Pasted image 20240922225030 Pasted image 20240922225105

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Sep 23, 2024
@taffyko taffyko marked this pull request as ready for review September 23, 2024 08:02
@taffyko taffyko requested a review from a team as a code owner September 23, 2024 08:02
@dbkr dbkr requested a review from a team September 23, 2024 08:34
@dbkr
Copy link
Member

dbkr commented Sep 23, 2024

Flagged for design review. Where did the design come from here (eg. the stripe colour)?

@taffyko
Copy link
Author

taffyko commented Sep 23, 2024

@dbkr The stripe takes cues from the layout we already use for selected messages (after following a link to a message)
image
with the color based on the contrast that Discord's similar highlighted-message style uses.
image

I had seen a few ticket comments from the community expressing the sentiment that (especially in light mode) the visibility of the "highlighted-message" background can be poor, and a style similar to Discord's would be appreciated — so I followed that sentiment in my design.
Apart from that, there was no formal design process for the stripe — but as a contributor, I'd love to learn how to get involved there!

I can drop it from the PR if it presents an issue.

@dbkr
Copy link
Member

dbkr commented Sep 23, 2024

Okay, thanks. The colour probably should come from one of the colours in the compound colour scheme already, if there's an appropriate one, but this is all for a designer to look at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications triggered by keywords don't decorate messages - Highlight keywords in a pill
2 participants