Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DB performance of calculating badge counts for push. #16756

Merged
merged 4 commits into from
Jan 11, 2024

Commits on Dec 21, 2023

  1. Improve DB performance of calculating badge counts for push.

    The crux of the change is to try and make the queries simpler and pull
    out fewer rows. Before, there were quite a few joins against subqueries,
    which caused postgres to pull out more rows than necessary.
    
    Instead, let's simplify the query and do some of the filtering out in
    Python instead, letting Postgres do better optimizations now that it
    doesn't have to deal with joins against subqueries.
    erikjohnston committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    da91285 View commit details
    Browse the repository at this point in the history
  2. Newsfile

    erikjohnston committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    2c270c9 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Apply suggestions from code review

    Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
    erikjohnston and anoadragon453 authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    bc1c795 View commit details
    Browse the repository at this point in the history
  2. Update synapse/storage/databases/main/event_push_actions.py

    Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
    erikjohnston and anoadragon453 authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    c9b5fca View commit details
    Browse the repository at this point in the history