fix: break words on hyphens for the an_a lint
#168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sentence "This is not an ML-based system." is grammatical, because the an/a vowel rule applies to "ML" (an initialism).
alex-ozdemir
force-pushed
the
an_a_hyphen
branch
from
0d55afb
to
836df1f
Compare
|
Looks great! Thanks for fixing it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sentence "This is not an ML-based system." is grammatical, because the an/a vowel rule applies to "ML" (an initialism).
Another approach would be to add a new document iterator (similar to
iter_words) that splits on hyphens too, and use that iterator.