Update polars to v0.27.2 #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may need some changes from this version to tackle these issues: - elixir-explorer#498 - elixir-explorer#499 See: pola-rs/polars#6487 And also the release: https://github.com/pola-rs/polars/releases/tag/rs-0.27.0 With this update we also had to change the `Explorer.DataFrame.describe/2` function to adhere the changes from Polars. I changed the backend to simplify, since we shouldn't have a lazy version.
josevalim
reviewed
Mar 9, 2023
| if let Ok(string) = std::str::from_utf8(&binary) { | ||
| series.utf8()?.fill_null_with_values(string)?.into_series() | ||
| if let Ok(_string) = std::str::from_utf8(&binary) { | ||
| // This casting is necessary just because it's not possible to fill UTF8 series. |
There was a problem hiding this comment.
Why not? Or do we need to cast the value we are filling? Which error do you get?
There was a problem hiding this comment.
@josevalim they removed the feature/function in this version. I couldn't find a replacement for this.
There was a problem hiding this comment.
ok, please try to find why they removed it but we can ship this anyway meanwhile!
There was a problem hiding this comment.
It's not clear the reason, but it was removed in this pull request: pola-rs/polars#6635 (line 369 of polars/polars-core/src/chunked_array/ops/fill_null.rs file).
josevalim
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may need some changes from this version to tackle these issues:
See: pola-rs/polars#6487
And also the release: https://github.com/pola-rs/polars/releases/tag/rs-0.27.0
With this update we also had to change the
Explorer.DataFrame.describe/2function to adhere the changes from Polars. I changed the backend to simplify, since we shouldn't have a lazy version.