Remove list guard in Plug.Conn.merge_assigns and merge_private #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please provide examples of use cases? |
|
I don't know why this limitation exists in the first place, I haven't found anything about this in original PR or commit messages Here's an example from my codebase static_assigns = static_assigns()
dynamic_assigns =
categories_assigns
|> Map.merge(item_assigns)
|> Map.merge(brands_assigns)
|> Map.merge(overrides)
|> Enum.to_list() # This is unnecessary
conn
|> merge_assigns(static_assigns)
|> merge_assigns(dynamic_assigns) |
|
I'm ok with a generic enumerable, but the |
hissssst
commented
May 25, 2023
hissssst
commented
May 25, 2023
whatyouhide
approved these changes
May 25, 2023
|
@whatyouhide @josevalim ping |
|
💚 💙 💜 💛 ❤️ |
bradhanks
pushed a commit
to bradhanks/plug
that referenced
this pull request
Sep 11, 2023
bradhanks
pushed a commit
to bradhanks/plug
that referenced
this pull request
Sep 11, 2023
bradhanks
pushed a commit
to bradhanks/plug
that referenced
this pull request
Sep 13, 2023
…r-plug#1152) drop 3627b20 Changed from passive to active voice, edited for consistency and conciseness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a more flexible solution