Make whitespace (more) optional in list strings #1155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Plug.Conn.Utils.list/1
would not handle all the whitespace around the commas if the space is before the comma.According to what I understand from
RFC9110§5.6.1
, lists should look like:With OWS (Optional White Space) on either side of the comma.
Right now I have it as handling only a single whitespace on either side, but we might have to clean up the string and then split, or clean it up after?
Examples
It should look like this:
But it looks like this:
Discuss