Fix non-string "_method" in Plug.MethodOverride #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyouhide
commented
Nov 14, 2023
| @@ -9,14 +9,33 @@ defmodule Plug.MethodOverride do | |||
| * `PATCH` | |||
| * `DELETE` | |||
|
|
|||
| This plug expects the body parameters to be already parsed and | |||
| fetched. Those can be fetched with `Plug.Parsers`. | |||
| This plug only replaces the request method if the `_method` request | |||
There was a problem hiding this comment.
Cleaned up docs to be more descriptive
|
|
||
| if method in @allowed_methods do | ||
| %{conn | method: method} | ||
| with method when is_binary(method) <- body_params["_method"] || "", |
There was a problem hiding this comment.
The fix here is the is_binary/1 guard.
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug we saw in production.