Plug.Static: Add support for preset MIME types #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Apr 2, 2024
lib/plug/static.ex
Outdated
| @@ -168,6 +175,7 @@ defmodule Plug.Static do | |||
| et_generation: Keyword.get(opts, :etag_generation, nil), | |||
| headers: Keyword.get(opts, :headers, %{}), | |||
| content_types: Keyword.get(opts, :content_types, %{}), | |||
| set_content_type: Keyword.get(opts, :set_content_type, true), | |||
There was a problem hiding this comment.
Instead of a new option, could we use content_types: false instead?
There was a problem hiding this comment.
Yes, this is a good idea, thanks! Updated the patch to extend content_types
It is not always possible to express custom types with a static filename -> type mapping. Currently Plug.Static will (if the file exists) always overwrite the header and halt the connection making it impossible to preset or later overwrite it based on custom logic. Thus introduce an opt-out mode to preserve whatever `Content-Type` was set or not set before.
TheOneric
force-pushed
the
static_set-content-type
branch
from
5ce29b2
to
6b8ffe3
Compare
whatyouhide
reviewed
Apr 3, 2024
whatyouhide
approved these changes
Apr 3, 2024
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not always possible to express custom types as a static filename -> type mapping. Currently
Plug.Staticwill (if the file exists) always overwrite the header and halt the connection making it impossible to preset or later overwrite it based on custom logic before callingPlug.Static.Thus introduce a new option to preserve whatever
Content-Typewas set or not set before.This may for example be useful when serving some user-uploaded files and it’s desired to still allow users to share e.g. CSS or JS snippets but to avoid security risks sanitise the
Content-Typeheader totext/plainand also setX-Content-Type-Options: nosniff.