Use Eask for CI #158
Merged
Use Eask for CI #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs090218
commented
Apr 24, 2022
| (with-current-buffer process-buffer | ||
| (setq-local default-directory (or project-root default-directory)) | ||
| (setq-local default-directory (or project-rt default-directory)) |
There was a problem hiding this comment.
I have temporary rename the variable to project-rt, or else the package-lint will give me the following error:
184:9: error: You should depend on (emacs "28.1") if you need ‘project-root’.
|
Thank you for this! |
ericdallo
approved these changes
Apr 24, 2022
No worries! We can fix this in the later PR. ;)
It's ready! :) |
This was referenced Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same PR with emacs-lsp/lsp-ui#700 and emacs-lsp/dap-mode#596
I think tests on Windows never work?