Fix JSON false values incorrectly being encoded as nulls in code actions #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy to use this if you think it's the right way to go. I would be open to trying to make HLS more permissive though, as I commented here: emacs-lsp/lsp-mode#4184 (comment) |
3 tasks
|
I think, at least for now, that doing both may be the way to go. Some more elaboration in the issue: emacs-lsp/lsp-mode#4184 (comment) |
michaelpj
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on emacs-lsp/lsp-mode#4194 to fix emacs-lsp/lsp-mode#4184 for HLS. This allows the code action to populate missing class members to work. Blocked on the aforementioned PR.