Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating configuration to support HLS 2.9.0.1 schema #186

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

asadoll
Copy link
Contributor

@asadoll asadoll commented Jul 29, 2024

Updating lsp-haskell plugins custom variables group to reflect HLS 2.9.0.1 configuration schema using haskell-language-server generate-default-config

Updating lsp-haskell plugins custom variables group to reflect HLS 2.9.0.1
@michaelpj
Copy link
Collaborator

Brilliant, thanks! I'm surprised there isn't more actually.

@michaelpj
Copy link
Collaborator

I'm a bit surprised the types for the token options haven't come through as choices, maybe the script doesn't handle that? annoying.

@asadoll
Copy link
Contributor Author

asadoll commented Jul 30, 2024

The script generates :tag choices which brings about warnings. Changed those to (const "option").
Update: Generated variable groups were also lsp-haskell.

@asadoll
Copy link
Contributor Author

asadoll commented Aug 18, 2024

@michaelpj would you please check the newer commits?

Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michaelpj michaelpj merged commit ba49fa9 into emacs-lsp:master Aug 26, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants