Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Eask for CI #3465

Closed
wants to merge 54 commits into from
Closed

Use Eask for CI #3465

wants to merge 54 commits into from

Conversation

jcs090218
Copy link
Member

This is the same PR with emacs-lsp/lsp-ui#700 and emacs-lsp/dap-mode#596

Special changes to this PR:

Unknown key: :something-unrelated.  Available keys: (:start :end)

It seems like I couldn't evaluate the test script directly ./test/lsp-protocol-test.el? Did I miss something?

@yyoncho
Copy link
Member

yyoncho commented Apr 14, 2022

The failing test is written like that:

    (should-error (pcase particular-range
                    ((MyRange :something-unrelated)
                     t)
                    (_ nil)))

So the error means the test should pass. I am not quite sure why this happens. Maybe the ci is running in a mode that means any error should break the job.

@jcs090218
Copy link
Member Author

Ah.. I think loading ERT shouldn't trigger any error. Now tests can be operated without stopping.

It leads to some interesting results:

ubuntu-latest, 27.1 (Cask)

LSP :: Shutdown pyls:3498 since folder /home/runner/work/lsp-mode/lsp-mode/test/fixtures is removed...
..............................................................

Ran 62 tests in 20.910 seconds

ubuntu-latest, 27.1 (Eask)

Ran 75 tests, 63 results as expected, 12 unexpected (2022-04-15 07:23:31+0000, 23.612242 sec)

12 unexpected results:
   FAILED  lsp-file-notifications-test
   FAILED  lsp-file-watch--adding-watches
   FAILED  lsp-file-watch--non-existing
   FAILED  lsp-file-watch--recursive
   FAILED  lsp-file-watch--relative-path-glob-patterns
   FAILED  lsp-org-position-translation-test
   FAILED  lsp-org-test-current-org-mode-content
   FAILED  lsp-org-transformation-of-did-change-events-1
   FAILED  lsp-org-transformation-of-did-change-events-2
   FAILED  lsp-test-pcase-patterns
   FAILED  lsp-transformation-of-did-change-events
   FAILED  lsp-virtual-position-to-point

Why are there tests 75 in Eask but only tests 62 in Cask? 😕 The tests seem to be accurate since I cannot get past these tests on my machine as well (Windows, Emacs 29.0.50).

Total of 80 ert-deftest appeared in the project, and 5 redefined tests. I assumed 75 is the correct number of the total test cases?

Image 1

@jcs090218 jcs090218 closed this Jun 21, 2022
@jcs090218 jcs090218 deleted the ci-eask branch December 5, 2022 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants