feat: use lsp-defcustom to declare settings for lsp-magik
#4525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiaanspeck
changed the title
lsp-defcustom to declare settings
|
@jcs090218 are you able to look at this PR? |
sebastiaanspeck
changed the title
lsp-defcustom to declare settingslsp-defcustom to declare settings for lsp-magik
|
Sure! Can you provide a little information regarding what this PR does in the first post? Just for the record and future reference. :) Overall, LGTM.! |
jcs090218
approved these changes
Aug 15, 2024
I noticed that the settings did not seem to be set correctly in the language server itself. Switching to lsp-defcustom changed this. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.