Correctly clean up lsp--update-signature-help-hook #4550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsp--update-signature-help-hook is not correctly removed when lsp-managed-mode is disabled.
Steps to reproduce:
open https://git.sr.ht/~davidcode/emacs-lsp-problem, and then try to disable lsp-mode and lsp-managed-mode
check the value of the variable post-self-insert-hook.
verified this change by running lsp-managed-mode (to turn it on and off) with the applied changes, and the post hook is no longer visible.
This has a real impact, as it pops up documentation strings, even after LSP mode is turned off.
Paired with David Howard on finding this issue.