-
-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add pwsh support for zip decompression, zls wrong bin path #4569
Conversation
I think PR #4472 will perhaps solve part of this issue. |
oh, yes |
Can you resolve the conflict (revert changes from |
I'm doing this, wait a minute |
If the ci test is normal after completion, it can be merged. |
Great, looks like it's ready to be merged |
lsp-ext-pwsh-script) | ||
((and (eq system-type 'windows-nt) | ||
(executable-find "powershell")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for powershell 5 @jcs090218
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! I guess line 8472 is no longer needed? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! I guess line 8472 is no longer needed? 🤔
Sorry, I forgot to modify line 8472. Powershell 5 only supports windows. This line should use pwsh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I resquashed and the problem was fixed
The current logic is that:
if you are on the windows platform, the priority of decompressing the zip is pwsh->powershell->unzip(bash)->pwsh(Do we still need to skip this step through the detection platform?)
other platform: unzip(bash)->pwsh
gnu is down again, causing the current ci test to not proceed normally |
ELPA is down, which causes the CI to fail. 😕 |
Thank you! |
The zip decompression of lsp-mode under the windows platform is damaged.
Emacs under windows will have a strange problem when using shell-command to execute bash commands. I have not found the reason to solve it.
Just like this:
(shell-command "bash -c 'echo hello && echo kk'")
Run it on emacs with Windows, and emacs will report error:
But this will work fine:
(shell-command "bash -c 'echo hello")
Then because emacs will give priority to using bash to create the directory and call unzip to perform the decompression operation (if unzip exists)
Feats: