Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vscode-eslint 3.0.10 #3

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Add vscode-eslint 3.0.10 #3

merged 1 commit into from
Jul 8, 2024

Conversation

ovistoica
Copy link
Contributor

I found some situations where repositories that use eslint "^9.4.0" are breaking with current lsp-eslint configuration.

It was weird because VSCode doesn't break. I tried to use the eslintServer from vscode and the issues weren't there anymore.

(use-package lsp-eslint
  :demand t
  :after lsp-mode
  :config
  (setq lsp-eslint-server-command `("node"
                                    "/Users/ovistoica/.vscode/extensions/dbaeumer.vscode-eslint-3.0.10/server/out/eslintServer.js"
                                    "--stdio")))

So I figured we should store this binary (eslint latest from marketplace https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint) for others too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants