embassy-boot (rp): Add WatchdogFlash #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integrating it into the flash feels a bit hacky. Perhaps we should add support for passing a watchdog into the bootloader? It would be yet another generic param though, so I'm not sure... |
Yeah, i was just mirroring the functionality of the nrf version here - i've been using it like this myself for a while and just thought i'd upstream it, but i agree it feels a little hacky... |
|
Oh, I wasn't aware nrf already did it this way. If so, I'm fine with doing it for rp too for now. We can revisit in the future. |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.