Fix Stream Test Failures #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this fixes errors mentioned in ember-animation#362, however it appears there are other failing tests that I don't have enough context to address. Will look into the other failures if I have some guidance.
|
Yes, this looks good. I think the other failures will go away if you try the latest ember-qunit (due to emberjs/ember-test-helpers#101). |
|
It looks like there are some remaining issues that were masked before by the qunit issue. |
|
(Doesn't need to block this PR though.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes errors mentioned in #362, however it appears there are other failing tests that I don't have enough context to address. Will look into the other failures if I have some guidance.