Skip to content

Commit

Permalink
Merge pull request #415 from ember-cli/drop-node-less-than-18
Browse files Browse the repository at this point in the history
Drop node < 18, unblocks 'Floating Dependencies' on #414
  • Loading branch information
ef4 authored Jun 10, 2024
2 parents b1493fe + 2a52206 commit b6cdd43
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 14
node-version: 18
cache: yarn
- name: Install Dependencies
run: yarn install --frozen-lockfile
Expand All @@ -40,7 +40,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 14
node-version: 18
cache: yarn
- name: Install Dependencies
run: yarn install --no-lockfile
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 14
node-version: 18
cache: yarn
- name: Install Dependencies
run: yarn install --frozen-lockfile
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Install node
uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
registry-url: 'https://registry.npmjs.org'

- name: install dependencies
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ If you add build metadata to the version, this addon will automatically append S

- Ember.js v3.28 or above
- Ember CLI v3.28 or above
- Node.js v14 or above
- Node.js v18 or above

## Installation

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"ember-source": "^3.28.0 || >= 4.0.0"
},
"engines": {
"node": "14.* || 16.* || >= 18"
"node": ">= 18"
},
"publishConfig": {
"registry": "https://registry.npmjs.org"
Expand Down

0 comments on commit b6cdd43

Please sign in to comment.