Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blueprints #123

Merged
merged 3 commits into from
Oct 25, 2016
Merged

Remove blueprints #123

merged 3 commits into from
Oct 25, 2016

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Aug 14, 2016

These blueprints have been moved into ember.js, ember-data and ember-cli-legacy-blueprints.

Merging this will require a major version bump (actually only a minor since we're still sub-1.0), but due to the JSHint removal that is necessary anyway.

This PR resolves #120, resolves #121 and obsoletes #81 and #118.

/cc @rwjblue

@Turbo87 Turbo87 force-pushed the remove-blueprints branch 2 times, most recently from c528e8e to 96a0227 Compare August 15, 2016 08:03
@Turbo87
Copy link
Member Author

Turbo87 commented Sep 4, 2016

@rwjblue any comments?

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 25, 2016

now that this is an ember-cli project: @ember-cli/core any comments?

They have been moved into "ember-core", "ember-data" and "ember-cli-legacy-blueprints"
@chadhietala
Copy link
Member

LGTM

@stefanpenner
Copy link

👍

@Turbo87 Turbo87 merged commit c9e927a into ember-cli:master Oct 25, 2016
@Turbo87 Turbo87 deleted the remove-blueprints branch October 25, 2016 16:19
@nathanhammond
Copy link

YESSS. 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent test names Disable JSHint "expr" rule
4 participants