Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation guide for (action) / {{action}} #1377

Merged
merged 7 commits into from
May 2, 2024
Merged

Deprecation guide for (action) / {{action}} #1377

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
39ca9bc
Deprecation guide for https://github.com/emberjs/rfcs/pull/1006
NullVoxPopuli Mar 5, 2024
ed72668
Prism happy?
NullVoxPopuli Mar 13, 2024
d87df18
More detail, more clarification
NullVoxPopuli Mar 13, 2024
5bfa180
Target 5.9.0
NullVoxPopuli Mar 14, 2024
9eb6905
Update deprecate-template-action.md
achambers Apr 17, 2024
7146afc
Merge branch 'main' into guide-for-template-action
achambers Apr 17, 2024
ea248cc
Update content/ember/v5/deprecate-template-action.md
NullVoxPopuli Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update content/ember/v5/deprecate-template-action.md 
Co-authored-by: Lukas Nys <nyslukas@gmail.com>
  • Loading branch information
@NullVoxPopuli @lukasnys
NullVoxPopuli and lukasnys committed Apr 17, 2024
commit ea248cc17c846a470da7ecc3328a6687fc37f3a9
2 changes: 1 addition & 1 deletion content/ember/v5/deprecate-template-action.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ If `(action)` or `{{action}}` is passed a string, it's _possible_ that the refer

Note that `@action` is completely different from `(action)` or `{{action}}` (and is partly a motivator for deprecating `(action)` and `{{action}}`, to reduce ambiguity).

`@action` is binds the `this` on the method to the instance of the class.
`@action` binds the `this` on the method to the instance of the class.


### Scenario: `action` is passed a function reference
Expand Down
Loading