-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Octane - new content to help avoid jQuery confusion #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelhan
reviewed
Jun 30, 2019
pzuraq
reviewed
Jul 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good! I think the "Back End Requests" name is a bit of a colloquialism, most people should get it and it may be better than the alternatives: "Making Network Requests", "Making API Requests", etc. I'm 👍 either way
pzuraq
approved these changes
Jul 12, 2019
lenoraporter
pushed a commit
to lenoraporter/guides-source
that referenced
this pull request
Jul 19, 2020
* remove jquery references * create a place to go over jquery, fetch, etc. centrally * change jquery optional features instructions * Remove redundant optional features instructions, replace with link * change back end page title to making api requests * fix api requests link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR helps address emberjs/rfc-tracking#3
The goal is to reflect that Octane will not have jQuery by default, and to give specific pointers to people about how to make API requests.
Added
Changed
Departures from RFC 431
I renamed "data management" to be "Making back end requests" because the "state management" topic clashes with the original name. I reviewed state management and I think it's too confusing to try and add this data fetching stuff to that guide. I expect it to keep growing.
I am open to renaming this section.
Next steps: