Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octane - new content to help avoid jQuery confusion #891

Merged
merged 6 commits into from
Jul 12, 2019
Merged

Conversation

jenweber
Copy link
Contributor

Purpose

This PR helps address emberjs/rfc-tracking#3

The goal is to reflect that Octane will not have jQuery by default, and to give specific pointers to people about how to make API requests.

Added

  • A new top-level topic and Guide that lays out options for loading data in an Ember app 🔥. This is a continuation of the effort to untangle how we teach Ember Data. This section will have more articles as time goes on and we get to the point where Ember Data can be a stand-alone guide.

Changed

  • I modified the "optional features" guide to reflect my understanding of the way jQuery will work in Octane apps
  • I removed a lingering jQuery reference

Departures from RFC 431

I renamed "data management" to be "Making back end requests" because the "state management" topic clashes with the original name. I reviewed state management and I think it's too confusing to try and add this data fetching stuff to that guide. I expect it to keep growing.

I am open to renaming this section.

Next steps:

  • another PR that finds the places where we should link to these pages
  • In places where we mention a fetch polyfill, instead move that info to this page and just link to this resource

@jenweber jenweber requested a review from pzuraq June 24, 2019 16:35
Copy link
Contributor

@pzuraq pzuraq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good! I think the "Back End Requests" name is a bit of a colloquialism, most people should get it and it may be better than the alternatives: "Making Network Requests", "Making API Requests", etc. I'm 👍 either way

@jenweber
Copy link
Contributor Author

Thanks for the feedback @jelhan and @pzuraq! I updated this PR to include it.

@jenweber jenweber merged commit 7ba3a83 into octane Jul 12, 2019
@jenweber jenweber deleted the jquery branch July 12, 2019 18:11
lenoraporter pushed a commit to lenoraporter/guides-source that referenced this pull request Jul 19, 2020
* remove jquery references

* create a place to go over jquery, fetch, etc. centrally

* change jquery optional features instructions

* Remove redundant optional features instructions, replace with link

* change back end page title to making api requests

* fix api requests link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants