Skip to content

Commit

Permalink
docs: tweak error message for no-element-event-actions rule
Browse files Browse the repository at this point in the history
  • Loading branch information
bmish committed Jun 15, 2019
1 parent 0e1b235 commit 6930ab9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions docs/rule/no-element-event-actions.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ This rule **allows** the following:

* [Deep Dive on Ember Events]
* Ember [Template Action](https://guides.emberjs.com/release/templates/actions/) documentation
* [Spec](https://api.emberjs.com/ember/release/classes/Ember.Templates.helpers/methods/action?anchor=action) for `action` helper
* [List of DOM Events](https://developer.mozilla.org/en-US/docs/Web/Events)

[Deep Dive on Ember Events]: https://medium.com/square-corner-blog/deep-dive-on-ember-events-cf684fd3b808
Expand Down
3 changes: 2 additions & 1 deletion lib/rules/lint-no-element-event-actions.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
const Rule = require('./base');
const AstNodeInfo = require('../helpers/ast-node-info');

const ERROR_MESSAGE = 'Do not use HTML element event properties with Ember actions.';
const ERROR_MESSAGE =
'Use Ember `{{action ...}}` helper instead of HTML element event properties like `onclick`.';

module.exports = class NoElementEventActions extends Rule {
visitor() {
Expand Down

0 comments on commit 6930ab9

Please sign in to comment.