[CLEANUP DEPRECATION errors] deprecates use of Ember.Evented with DS.Errors #5663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
changed the title
|
After team discussion we've decided it would be better to send this through a true deprecation cycle, which would involve (unfortunately) renaming the methods. An RFC will be presented for the deprecation. |
|
RFC has been opened here: emberjs/rfcs#384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is tricky. We inserted warnings that we would eliminate mutating record-state from DS.Errors a very long time ago, but due to the mechanics of it all could not truly "deprecate". This "finalizes" that weirdly managed deprecation.
It also removes the
@deprecatedlabel from methods where it is incorrectly present.It also introduces the
Eventeddeprecation from RFC#329 forDS.Errorsin a way that other classes that will need to deprecate events can also utilize.