Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont trust ember-inflector #9497

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix: dont trust ember-inflector #9497

merged 1 commit into from
Jun 20, 2024

Conversation

runspired
Copy link
Contributor

ember-inflector mutates the singular and plural default arrays with user provided values, so to detect rules that aren't defaults we need to use our own list.

@runspired runspired added 🎯 beta PR should be backported to beta 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue labels Jun 20, 2024
@runspired runspired merged commit 1b8b497 into main Jun 20, 2024
18 of 22 checks passed
@runspired runspired deleted the better-init branch June 20, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 beta PR should be backported to beta 🎯 canary PR is targeting canary (default) 🎯 release PR should be backported to release 🏷️ bug This PR primarily fixes a reported issue
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant