Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Be more helpful when failing #9532

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Be more helpful when failing #9532

wants to merge 1 commit into from
+3 −1

Conversation

MichalBryxi
Copy link
Contributor

Description

  • Current message of "Error: Multiple versions of WarpDrive detected, the application will malfunction." is hard to action on as it does not give the user enough context on what it sees.
  • Make it so that the user has some idea what configuration made the app fail.

Notes for the release

  • When multiple versions of warp-drive are found, tell the user which ones while failing.

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature labels Sep 17, 2024
@MichalBryxi
fix: Be more helpful when failing
c787151 
- Current message of "Error: Multiple versions of WarpDrive detected, the application will malfunction." is hard to action on as it does not give the user enough context on what it sees.
- Make it so that the user has _some_ idea what configuration made the app fail.
@MichalBryxi
Copy link
Contributor Author

Fixed the prettier error, but not sure what does the "Main / releases (ember-canary) (pull_request)" complain about? @runspired?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runspired runspired runspired approved these changes

@anandfresh anandfresh anandfresh approved these changes

Assignees
No one assigned
Labels
🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature
Projects
EmberData
Status: needs triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichalBryxi @runspired @anandfresh