Remove the "Disable linting" checkbox

[nelstrom]

Addresses #1139.

This PR does two things:

1. It removes the "Disable linting" checkbox
2. It removes references to the nolint query param from the implementation

Removing the checkbox is my main goal with this PR, whereas removing references to nolint is just me being thorough. It's possible that we want to keep the nolint handling in place for the sake of backwards compatibility, in which case I'm happy to revert the second change.

Before:

After:

[nelstrom]

As an afterthought: maybe it's worth including some documentation instructing how to add the "Disable linting" checkbox back, for anyone who still uses this feature?

[NullVoxPopuli]

Before determining if this is a fix or breaking change, is there a way you can check if ember-cli-template-lint or ember-cli-eslint:

• work within the supported
  • ember-cli range: ember-cli ~v4.8.1, ~v4.12.2, >= v5.1
  • ember-auto-import@v2
  • node 16+
• introduce their own "Disable linting" flag
• what happens if locally, ember-qunit doesn't have Disable linting, and someone wants to disable linting and happens to have one of the ember-cli*lint packages installed?

Thank you!!!!

If the answer to the first is "no", or if the answer to the second is "yes", then we don't need to worry about compat.

[nelstrom]

@NullVoxPopuli to investigate that, would it be a question of doing the following:

1. Using ember-cli version 4.8.1, run ember new to create a new app
2. In the new app, install ember-cli-eslint
3. Make the new app use Node v16 and ember-auto-import@v2
4. Check that the new app runs ok

If that all works, then I could replace the ember-qunit dependency with the version in this branch, and see if it causes anything to break.

Does that sound like a plan? Or did I misunderstand you?

[nelstrom]

Taking a closer look at the package.json file in ember-cli-eslint, a few things jump out at me:

1. "node": "6.* || 8.* || >= 10.*"
2. "ember-cli": "~3.9.0",
3. "ember-cli-qunit": "^4.3.2", - it doesn't depend on ember-qunit, but instead depends on ember-cli-qunit (also deprecated)
4. No mention of ember-auto-import

This is an addon from the pre-Octane era of Ember. It's going to be difficult to get ember-cli-eslint working with any of the current LTS releases of Ember/EmberCLI.

[NullVoxPopuli]

True, so, because ef that ember-cli range, it's not something we need to worry about. Excellent! Thanks for looking!