Updated README.md with newer syntax #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will have some overlap with the Ember guides, but since those are in process I wanted to take a stab at providing some documentation for how the unit / integration tests work in components.
|
Thanks for the PR! I'll try to review in detail soon, and give some feedback... |
| assert.ok(panel1.$().is(':visible')); | ||
|
|
||
| // render the component | ||
| this.render('{{ x-foo value=value action="result" }}'); |
There was a problem hiding this comment.
This misses the hbs inline template compiler function.
|
This looks great!! I left some inline comments, but nothing major. |
|
@rwjblue / @martndemus thanks for the feedback. Changes should be good to go. |
rwjblue
added a commit
that referenced
this pull request
Jul 29, 2015
Updated README.md with newer syntax
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will have some overlap with the Ember guides, but since those are in process I wanted to take a stab at providing some documentation for how the unit / integration tests work in components.