Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Convert to TypeScript #994

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

WIP: Convert to TypeScript #994

wants to merge 34 commits into from

Conversation

gitKrystan
Copy link
Contributor

@gitKrystan gitKrystan commented Dec 10, 2022

A better fix for #957

Requires:
ember-cli/ember-cli-test-loader#77 (optional)
emberjs/ember-test-helpers#1319 (merged, NEEDS RELEASE)
@types/qunit changes: DefinitelyTyped/DefinitelyTyped#63805 (DONE: merged, released)
#1017 (DONE: merged)

@@ -45,6 +45,35 @@ module.exports = {
extends: ['plugin:node/recommended'],
},

// ts files
{
Copy link
Contributor Author

@gitKrystan gitKrystan Dec 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove this if you don't like UBER-STRICTNESS, but I find it useful during conversion at least

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
"addon-test-support/**/*"
],

// type checking
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so strict lolol

@@ -0,0 +1,17 @@
declare module 'ember-cli-test-loader/test-support/index' {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we port these to the library in question? Yaks on yaks on yaks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can either merge this as is or release ember-cli/ember-cli-test-loader#77 and switch to using that.

@@ -15,6 +15,8 @@
!.*
.*/
.eslintcache
/.yalc*
/yalc.lock
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can revert once emberjs/ember-test-helpers#1319 is released

@@ -20,6 +20,9 @@
/npm-debug.log*
/testem.log
/yarn-error.log
/.yalc*
/yalc.lock
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can revert once emberjs/ember-test-helpers#1319 is released

@@ -15,6 +15,8 @@
!.*
.eslintcache
.lint-todo/
/.yalc*
/yalc.lock
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can revert once emberjs/ember-test-helpers#1319 is released

package.json Outdated
@@ -49,12 +52,14 @@
"@babel/core": "^7.20.5",
"@babel/eslint-parser": "^7.19.1",
"@ember/optional-features": "^2.0.0",
"@ember/test-helpers": "^2.9.3",
"@ember/test-helpers": "file:.yalc/@ember/test-helpers",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME once emberjs/ember-test-helpers#1319 is released

@@ -0,0 +1,37 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review closely bc I've been known to muck these things up :-P

@@ -88,7 +93,7 @@
"qunit": "^2.13.0"
},
"engines": {
"node": "14.* || 16.* || >= 18"
"node": "16.* || >= 18"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed for latest @ember/test-helpers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant