Merge pull request #48 from rwjblue/allow-missing-callbacks-for-compo…

…nents Allow missing arguments for `moduleForComponent`.
emberjs · May 14, 2015 · 05e932d · 05e932d
2 parents 0a514b2 + ef2df07
commit 05e932d
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/ember-test-helpers/test-module-for-component.js b/lib/ember-test-helpers/test-module-for-component.js
@@ -6,8 +6,10 @@ export default TestModule.extend({
   init: function(componentName, description, callbacks) {
     // Allow `description` to be omitted
     if (!callbacks && typeof description === 'object') {
-      callbacks = description || {};
+      callbacks = description;
       description = null;
+    } else if (!callbacks && !description) {
+      callbacks = {};
     }
 
     this.componentName = componentName;

diff --git a/tests/test-module-for-component-test.js b/tests/test-module-for-component-test.js
@@ -252,3 +252,21 @@ test("className", function(){
   expect(1)
   // the assertion is in the willDestroyElement() hook of the component
 });
+
+var testModule;
+module('moduleForComponent: can be invoked with only the component name', {
+  beforeEach: function(assert) {
+    var done = assert.async();
+    testModule = new TestModuleForComponent('pretty-color');
+    testModule.setup()['finally'](done);
+  },
+
+  afterEach: function(assert) {
+    var done = assert.async();
+    testModule.teardown()['finally'](done);
+  }
+});
+
+test('it allows missing callbacks', function() {
+  ok(true, 'no errors are thrown');
+});