Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs no longer optional in v0.4.4? Unit tests deprecated? #47

Closed
bjornstar opened this issue May 14, 2015 · 1 comment · Fixed by #48
Closed

Needs no longer optional in v0.4.4? Unit tests deprecated? #47

bjornstar opened this issue May 14, 2015 · 1 comment · Fixed by #48

Comments

@bjornstar
Copy link

not ok 160 PhantomJS 1.9 - TestLoader Failures tests/unit/components/ui-selectable-item-test: could not be loaded
    ---
        message: >
            'undefined' is not an object (evaluating 'callbacks.needs')
        stack: >
            TypeError: 'undefined' is not an object (evaluating 'callbacks.needs')
                at http://localhost:7357/assets/test-support.js:1937
                at http://localhost:7357/assets/test-support.js:2426
                at http://localhost:7357/assets/test-support.js:2468
                at createModule (http://localhost:7357/assets/test-support.js:1728)
                at describeComponent (http://localhost:7357/assets/test-support.js:1622)
                at http://localhost:7357/assets/my-app.js:69026
                at http://localhost:7357/assets/vendor.js:150
                at tryFinally (http://localhost:7357/assets/vendor.js:30)
                at http://localhost:7357/assets/vendor.js:156
                at http://localhost:7357/assets/test-loader.js:29
                at http://localhost:7357/assets/test-loader.js:21
                at http://localhost:7357/assets/test-loader.js:40
                at http://localhost:7357/assets/test-support.js:14780
        Log: >
    ...

Would it be too much to get a changelog for v0.4.4?

When you do a major API change (like deprecating unit tests), I would expect something more than a patch level version bump. This was a very unpleasant suprise.

@rwjblue
Copy link
Member

rwjblue commented May 14, 2015

Yes, I agree. It was my mistake, I am sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants