Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component integration tests used deprecated Ember.View #59

Closed
ef4 opened this issue Jun 14, 2015 · 6 comments
Closed

Component integration tests used deprecated Ember.View #59

ef4 opened this issue Jun 14, 2015 · 6 comments

Comments

@ef4
Copy link
Contributor

ef4 commented Jun 14, 2015

Ember has deprecated all use of Ember.View, which is used in (at least) component integration test setup.

I can probably work on this later today.

@toranb
Copy link

toranb commented Jul 14, 2015

@ef4 I just noticed this today using ember 1.13.3/1.13.4

Any chance this is a simple update/bump?

@ef4
Copy link
Contributor Author

ef4 commented Jul 14, 2015

The original issue I mentioned above got fixed via #60, #61, and #62, and at the time those were sufficient to get us running cleanly against Ember 1.13. But more deprecations have landed in Ember now.

@toranb
Copy link

toranb commented Jul 16, 2015

Not a problem - just curious what I can do to help/what your timeline was to resolve this/what might be coming in the 1.13.5 release that we should think about as we fix this

thanks again for all your great work on this project! I get a ton of value from it :)

@blimmer
Copy link
Contributor

blimmer commented Jul 20, 2015

With 2.0.0-beta.3, this causes test failures (as seen here)

@rwjblue
Copy link
Member

rwjblue commented Jul 20, 2015

Confirm, this has jump into big deal territory now...

@rwjblue
Copy link
Member

rwjblue commented Jul 20, 2015

Fixed by #79, #80, and #81.

@rwjblue rwjblue closed this as completed Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants