Compatibility with Ember 1.13+ #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Why are all the tests failing? |
|
Ha, because I leaked ES6, and it happened to work natively in Chrome. |
This cleans up deprecations for use with Ember 1.13+, plus one small private API break (the changed `Resolver.create()` call). The removed tests were all testing container resolution of things that are deprecated. There is still coverage for container resolution of Components, which should be sufficient. The test suite still emits a several deprecations, but they are all coming from Ember Data and will need to get fixed there. I paired with @stefanpenner for this PR.
|
Fixed, Travis is green. |
| equal(component._state, 'inDOM'); | ||
| }); | ||
|
|
||
| test('can lookup default Ember.Views in its layout', function() { |
There was a problem hiding this comment.
We should replace this one with a {{component}} helper version (not blocking this PR though).
There was a problem hiding this comment.
Sounds good, I will work on that, since I also noticed another incompatibility with the new deprecations.
rwjblue
added a commit
that referenced
this pull request
Jun 14, 2015
Compatibility with Ember 1.13+
ef4
added a commit
to ef4/ember-test-helpers
that referenced
this pull request
Jun 15, 2015
As suggested by @rwjblue [here](emberjs#60 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up deprecations for use with Ember 1.13+, plus one small
private API break (the changed
Resolver.create()call).The removed tests were all testing container resolution of things that
are deprecated. There is still coverage for container resolution of
Components, which should be sufficient.
The test suite still emits a several deprecations, but they are all
coming from Ember Data and will need to get fixed there.
I worked on this PR with @stefanpenner.
This PR also supersedes #42, which was ready to go and relevant.