Ensure blur event fires on prior focused element even if click target is not focusable
#1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1032 |
rwjblue
reviewed
May 25, 2021
helgablazhkun
force-pushed
the
click-helper-blur-fix
branch
from
1bac7d4
to
5766d0e
Compare
|
Moved 'isFocusable' check and blur into focus. |
rwjblue
reviewed
May 27, 2021
helgablazhkun
force-pushed
the
click-helper-blur-fix
branch
from
5766d0e
to
10e4091
Compare
The root cause of the issue is that the blur event is not triggered on the current active element in the __focus__ helper in case if the clicked (double-clicked, tapped) element is not focusable. If the clicked (double-clicked, tapped) element is focusable the previous active element gets blur event trough the __focus__ helper. A call to __blur__ was added to the __focus__ helper for the case when the clicked (double-clicked, tapped) element element is not focusable.
helgablazhkun
force-pushed
the
click-helper-blur-fix
branch
from
10e4091
to
1e0c6a4
Compare
rwjblue
changed the title
blur event fires on prior focused element even if click target is not focusable
This was referenced Sep 9, 2021
|
Hey @rwjblue and @helgablazhkun, this is a great improvement, and definitely moves things in the right direction! However, it has turned out to be a pretty significantly breaking change for my test suite -- see #1126 and #1127. I guess it's already released, but maybe we can fast-track those PRs to minimize the time that the latest version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of the issue is that the blur event is not triggered on
the current active element in the click helper in case if the clicked
element is not focusable.
If the clicked element is focusable the previous active element gets
blur event trough the focus helper.
A call to blur was added for the case when the clicked element
is not focusable.