Fix ember-canary related issue in tests #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember.DefaultResolver is no more, so rather trying to use it, we will simply rely on the basic resolver protocol. That way, not concrete object is needed, and we are future proof until such time as that changes.
rwjblue
approved these changes
Aug 3, 2021
stefanpenner
force-pushed
the
fix-resolver-extend
branch
2 times, most recently
from
f4c7998
to
638b376
Compare
Ember.DefaultResolver is no more, so rather trying to use it, we will simply rely on the basic resolver protocol. That way, not concrete object is needed, and we are future proof until such time as that changes.
stefanpenner
force-pushed
the
fix-resolver-extend
branch
from
638b376
to
aecd1a0
Compare
rwjblue
approved these changes
Aug 4, 2021
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember.DefaultResolver is no more, so rather trying to use it, we will simply rely on the basic resolver protocol. That way, not concrete object is needed, and we are future proof until such time as that changes.