-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add start
and end
hooks to the fireEvent
helper
#1185
Merged
Merged
Changes from 33 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
eded8e7
feat: add `start` and `end` hooks to `fireEvent` helper
5b2c2ae
refactor: migrate blur, click, focus, tap to fire async events
1b89095
refactor: migrate fillIn, typeIn to fire async events
599ae74
docs: add details to JSDoc
d488116
test: move all register hook tests into helper modules
31b62f8
refactor: promisify `triggerEvent` helper
2690988
chore: remove lingering import
37a9414
refactor: promisify `doubleClick` helper
ab797ef
test: add more/improve register hooks helpers
96ea125
refactor: always return Promise for focus step
c6e3ff2
test: add assertions for fire event hook steps
f292678
test: use improved hook test helpers
2e8de27
test: use improved hook test helpers
4318212
docs: clarify param description
f410f57
refactor: promisify `tab` fire event func
0a6e687
refactor: promisify `trigger-key-event` helper
786c245
refactor: promisify `select` helper
f633cf1
test: add event hooks assertions to execution test
c7c851f
test: rename helper `eventTypes` params to `expectedEvents`
2d6170c
test: use hook test helpers
93bc5df
chore: remove finished TODOs
9ded7a2
refactor: encapsulate specific start/end hooks with generic hooks
b70b17a
refactor: fully promisify `fillIn` helper
ef8f92b
fix: re-add `settled` func after events fired
b2f08fe
chore: remove unused imports
03db0d7
refactor: promisify `scrollTo` helper
7506700
test: add event hooks assertions to execution test
add69f6
refactor: restore prior `settled` behaviour
5b7bf9c
refactor: let -> const
03f93db
chore: remove unused import
056a8b3
chore: restore import statements order
51af5a4
refactor: flatten Promise chain
53815e0
test: improve helper readability
27cde93
refactor: add fallback Promise resolution
f1ff128
Revert "refactor: let -> const"
126d4b0
Revert "test: use hook test helpers"
1bab92a
revert: undo unrelated assertion replacements
1fb879a
revert: restore chained `settled` Promise
61cfbb3
revert: restore `_registerHook` import
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the flexibility this provides. It's a nice composition of general to specific!