Add support for integration: 'legacy'
#121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This semantics of the `integration` flag have changed in a backwards-incompatible way since v0.4.3. This corresponds to an ember upgrade (using ember-cli) between v1.12 and v1.13. In order to ease this upgrade path for ember-cli users, `integration: 'legacy'` will set up a component test with v0.4.3 semantics. Of course, newer tests would still be encouraged to be written with `integration: true`.
|
This looks good to me, we'll need to add a deprecation when using |
|
I'm going to merge this, and submit a follow up PR to tweak |
rwjblue
added a commit
that referenced
this pull request
Nov 23, 2015
Add support for `integration: 'legacy'`
|
Follow up PR: #122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This semantics of the
integrationflag have changed in a backwards-incompatible way since v0.4.3. This corresponds to an ember upgrade (using ember-cli) between v1.12 and v1.13.In order to ease this upgrade path for ember-cli users,
integration: 'legacy'will set up a component test with v0.4.3 semantics. Of course, newer tests would still be encouraged to be written withintegration: true.Replacement PR for #115.
/cc @hjdivad